From: Marco Pesenti Gritti <marco@gnome.org>
Date: Fri, 7 Jan 2005 15:05:52 +0000 (+0000)
Subject: add a FIXME. We should probably not allocate a bookmark object every time
X-Git-Tag: EVINCE_0_1_0~3
X-Git-Url: https://www.fi.muni.cz/~kas/git//home/kas/public_html/git/?a=commitdiff_plain;h=4dd8f5ed4440055665f564818a762663a8390310;p=evince.git

add a FIXME. We should probably not allocate a bookmark object every time

2005-01-07  Marco Pesenti Gritti  <marco@gnome.org>

        * pdf/xpdf/pdf-document.cc:

        add a FIXME. We should probably not allocate
        a bookmark object every time
---

diff --git a/ChangeLog b/ChangeLog
index ca0222cc..1b3fc228 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,3 +1,10 @@
+2005-01-07  Marco Pesenti Gritti  <marco@gnome.org>
+
+	* pdf/xpdf/pdf-document.cc:
+
+	add a FIXME. We should probably not allocate
+	a bookmark object every time
+
 2005-01-07  Marco Pesenti Gritti  <marco@gnome.org>
 
 	* shell/ev-application.c: (ev_application_open),
diff --git a/pdf/xpdf/pdf-document.cc b/pdf/xpdf/pdf-document.cc
index 6e077162..6f137dd9 100644
--- a/pdf/xpdf/pdf-document.cc
+++ b/pdf/xpdf/pdf-document.cc
@@ -740,6 +740,8 @@ pdf_document_bookmarks_begin_read (EvDocumentBookmarks *document_bookmarks)
 	return (EvDocumentBookmarksIter *) iter;
 }
 
+/* FIXME This returns a new object every time, probably we should cache it
+   in the iter */
 static EvBookmark *
 pdf_document_bookmarks_get_bookmark (EvDocumentBookmarks      *document_bookmarks,
 				     EvDocumentBookmarksIter  *bookmarks_iter)