Do not connect selection changed signal more than once. Fixes bug #349433.

2007-07-01  Carlos Garcia Campos  <carlosgc@gnome.org>
	* shell/ev-sidebar-links.c: (job_finished_callback):
	Do not connect selection changed signal more than once. Fixes bug
	#349433.

svn path=/branches/gnome-2-18/; revision=2532

diff --git a/ChangeLog b/ChangeLog
index d948bd11f9fc4ea36c8287a02e1e0db746ae59a9..4c7215a6bef2abe08079dd5814eec82403b252b5 100644 (file)
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,3 +1,10 @@
+2007-07-01  Carlos Garcia Campos  <carlosgc@gnome.org>
+
+       * shell/ev-sidebar-links.c: (job_finished_callback):
+
+       Do not connect selection changed signal more than once. Fixes bug
+       #349433.
+       
 2007-06-29  Carlos Garcia Campos  <carlosgc@gnome.org>
 
        * shell/ev-window.c: (ev_window_view_sidebar_cb):

diff --git a/shell/ev-sidebar-links.c b/shell/ev-sidebar-links.c
index 5d3469543e12bb49030165b8c7a76a6208c60c50..e36c17e79cf9c17d018a83767801c42e9382ade7 100644 (file)
--- a/shell/ev-sidebar-links.c
+++ b/shell/ev-sidebar-links.c
@@ -648,18 +648,24 @@ job_finished_callback (EvJobLinks     *job,
 
        selection = gtk_tree_view_get_selection (GTK_TREE_VIEW (priv->tree_view));
        gtk_tree_selection_set_mode (selection, GTK_SELECTION_SINGLE);
-       priv->selection_id = g_signal_connect (selection, "changed",
-                                              G_CALLBACK (selection_changed_callback),
-                                              sidebar_links);
+       if (priv->selection_id <= 0) {
+               priv->selection_id =
+                       g_signal_connect (selection, "changed",
+                                         G_CALLBACK (selection_changed_callback),
+                                         sidebar_links);
+       }
        priv->page_changed_id = g_signal_connect (priv->page_cache, "page-changed",
                                                  G_CALLBACK (update_page_callback),
                                                  sidebar_links);
-       priv->row_activated_id = g_signal_connect (G_OBJECT (priv->tree_view), "row-activated",
-                                                   G_CALLBACK (row_activated_callback), sidebar_links);
+       if (priv->row_activated_id <= 0) {
+               priv->row_activated_id =
+                       g_signal_connect (G_OBJECT (priv->tree_view), "row-activated",
+                                         G_CALLBACK (row_activated_callback),
+                                         sidebar_links);
+       }
        update_page_callback (priv->page_cache,
                              ev_page_cache_get_current_page (priv->page_cache),
                              sidebar_links);
-
 }
 
 static void