Make sure to always set @error when returning FALSE.

[evince.git] / backend / tiff / tiff-document.c

diff --git a/backend/tiff/tiff-document.c b/backend/tiff/tiff-document.c
index 6969a1bdfc2e08f70c88f6094ef34aa4344e0ade..5501451cd5829a1c5be6765f3ab581cc51c0bbd0 100644 (file)
--- a/backend/tiff/tiff-document.c
+++ b/backend/tiff/tiff-document.c
@@ -91,13 +91,11 @@ tiff_document_load (EvDocument  *document,
        gchar *filename;
        TIFF *tiff;
        
-       push_handlers ();
        filename = g_filename_from_uri (uri, NULL, error);
-       if (!filename) {
-               pop_handlers ();
+       if (!filename)
                return FALSE;
-       }
        
+       push_handlers ();
        tiff = TIFFOpen (filename, "r");
        if (tiff) {
                guint32 w, h;
@@ -109,6 +107,13 @@ tiff_document_load (EvDocument  *document,
        
        if (!tiff) {
                pop_handlers ();
+
+               g_set_error_literal (error,
+                                    EV_DOCUMENT_ERROR,
+                                    EV_DOCUMENT_ERROR_INVALID,
+                                    _("Invalid document"));
+
+               g_free (filename);
                return FALSE;
        }