]> www.fi.muni.cz Git - bike-lights.git/commitdiff
Revert "adc.c: make the ADC handlers non-atomic"
authorJan "Yenya" Kasprzak <kas@fi.muni.cz>
Wed, 27 Feb 2013 21:49:42 +0000 (22:49 +0100)
committerJan "Yenya" Kasprzak <kas@fi.muni.cz>
Wed, 27 Feb 2013 21:49:42 +0000 (22:49 +0100)
This reverts commit eb2f91ea7806fd8f5b9a5597fcf5c13855911d71.

We will probably not need non-atomic handlers.

firmware/adc.c

index 9155f325ccfd2c857a93c503b2c2f6337a78ad04..6ef638a5c79204f20251608db63371bfd51a3fc6 100644 (file)
@@ -1,6 +1,5 @@
 #include <avr/io.h>
 #include <avr/interrupt.h>
-#include <util/atomic.h>
 
 #include "lights.h"
 
@@ -15,7 +14,6 @@ static unsigned char sum_shift;
 static unsigned char adc_vals;
 #define ADC1_GAIN20_OFFSET_SHIFT       6
 static uint16_t adc1_gain20_offset;
-static unsigned char handler_running;
 
 static void inline setup_mux(unsigned char n)
 {
@@ -88,7 +86,6 @@ void init_adc()
 {
        unsigned char i;
        current_adc = NUM_ADCS;
-       handler_running = 0;
 
        ADCSRA = _BV(ADEN)                      // enable
                | _BV(ADPS1) | _BV(ADPS0)       // CLK/8 = 125 kHz
@@ -157,28 +154,13 @@ ISR(ADC_vect) { // IRQ handler
                        adc_sum = 0;
        }
 
-       if (handler_running & (1 << current_adc)) {
-               log_byte(0xB0 + current_adc);
-
-               // drop the result, what else to do?
-
-               start_next_adc();
-       } else {
-               unsigned char current_adc_copy = current_adc;
-               uint16_t adc_sum_copy = adc_sum;
-
-               start_next_adc();
-
-               handler_running |= (1 << current_adc_copy);
-               NONATOMIC_BLOCK(NONATOMIC_FORCEOFF) {
-                       if (current_adc_copy < N_PWMLEDS)
-                               pwmled_adc(current_adc_copy, adc_sum_copy);
-                       if (current_adc_copy == AMBIENT_ADC)
-                               ambient_adc(adc_sum_copy);
-                       if (current_adc_copy == BATTERY_ADC)
-                               battery_adc(adc_sum_copy);
-               }
-               handler_running &= ~(1 << current_adc_copy);
-       }
+       if (current_adc < N_PWMLEDS)
+               pwmled_adc(current_adc, adc_sum);
+       if (current_adc == AMBIENT_ADC)
+               ambient_adc(adcval);
+       if (current_adc == BATTERY_ADC)
+               battery_adc(adcval);
+       
+       start_next_adc();
 }