mudflap for dual rearlights

[bike-lights.git] / firmware / pattern.c

diff --git a/firmware/pattern.c b/firmware/pattern.c
index 3354c6f5e5d59b8a46e4c5991d736ab70e6e4a55..b4edcc4309a4df77b3a5a57f79c1307b255e3712 100644 (file)
--- a/firmware/pattern.c
+++ b/firmware/pattern.c
@@ -85,13 +85,40 @@ pattern_t off_pattern[] = {
        PATTERN_END
 };
 
-static void led_set_mode(unsigned char n, unsigned char mode)
+/*
+ * This is tricky: we use a single pattern for all three pwmleds,
+ * but on some occasions, we want to be able to modify only a single
+ * pwmled status without affecting other outputs. For example, during
+ * braking, we want to modify only the rear pwmled status. We don't
+ * use a separate "braking" pattern for every other pattern used, but instead
+ * we change the pwmled0 status regardless of the original value when
+ * braking. The rule is the following:
+ * - if during braking the pwmled2 (front) is at mode 2, we switch it to
+ *   mode 3 (which has the same target current) to avoid flicker.
+ * - if pwmled0 (rear) is off, we set it to mode 2
+ *     (if it is with mode 1, we keep it at mode 1)
+ * TODO: something similar should be done for the "entering the dark area"
+ *     condition, where we want to switch pwmled2 (front) on, to mode 2.
+ */
+void pwmleds_update_mode()
 {
-       if (n < N_PWMLEDS) {
-               pwmled_set_mode(n, mode);
-       } else if (n < N_LEDS) {
-               gpio_set(n - N_PWMLEDS, mode);
+       unsigned char mode, mode0, mode1, mode2;
+
+       mode = led_patterns[0]->mode;
+
+       mode0 = mode & 3;
+       mode1 = (mode >> 2) & 1;
+       mode2 = (mode >> 3) & 3;
+
+       if (err_flags.braking && !err_flags.err_battery) {
+               mode0 = 2;
+               if (mode2 == 2)
+                       mode2 = 3;
        }
+
+       pwmled_set_mode(0, mode0);
+       pwmled_set_mode(1, mode1);
+       pwmled_set_mode(2, mode2);
 }
 
 void led_set_pattern(unsigned char n, pattern_t *pattern)
@@ -103,7 +130,11 @@ void led_set_pattern(unsigned char n, pattern_t *pattern)
 
        led_counters[n] = fibonacci[pattern->duration_fib];
 
-       led_set_mode(n, pattern->mode);
+       if (n == 0) {
+               pwmleds_update_mode();
+       } else if (n < N_LEDS) {
+               gpio_set(n - 1, pattern->mode);
+       }
 }
 
 void init_pattern()
@@ -113,7 +144,7 @@ void init_pattern()
        for (i = 0; i < N_LEDS; i++)
                led_set_pattern(i, NULL);
 
-       led_set_pattern(N_PWMLEDS+1, boot_pattern);
+       led_set_pattern(N_ILLUM_LED, boot_pattern);
 }
 
 pattern_t *number_pattern(unsigned char num, unsigned char inv)
@@ -135,12 +166,10 @@ pattern_t *number_pattern(unsigned char num, unsigned char inv)
 static pattern_t *pattern_select(unsigned char n)
 {
        switch(n) {
-       case 0: return pwmled0_pattern_select();
-       case 1: return pwmled1_pattern_select();
-       case 2: return pwmled2_pattern_select();
-       case 3: return status_led_pattern_select();
-       case 4: return illumination_led_pattern_select();
-       case 6: return laser_pattern_select();
+       case 0: return pwmled_pattern_select();
+       case N_STATUS_LED: return status_led_pattern_select();
+       case N_ILLUM_LED:  return illumination_led_pattern_select();
+       case N_LASER_LED:  return laser_pattern_select();
        default: return NULL;
        }
 }
@@ -159,20 +188,16 @@ static void inline pattern_finished(unsigned char n)
 
        led_patterns[n] = NULL;
 
-       if (n < N_PWMLEDS) {
-               for (i = 0; i < N_PWMLEDS; i++)
-                       if (led_patterns[i])
-                               return;
-
-               /* all pwmleds finished; restart them */
-               for (i = 0; i < N_PWMLEDS; i++)
-                       led_set_pattern(i, pattern_select(i));
-       } else if (n == 3) {
-               if (!led_patterns[4])
-                       led_set_pattern(4, pattern_select(4));
-       } else if (n == 4) {
-               if (!led_patterns[3])
-                       led_set_pattern(3, pattern_select(3));
+       if (n == 0) {
+               led_set_pattern(0, pattern_select(0));
+       } else if (n == N_STATUS_LED) {
+               if (!led_patterns[N_ILLUM_LED])
+                       led_set_pattern(N_ILLUM_LED,
+                               pattern_select(N_ILLUM_LED));
+       } else if (n == N_ILLUM_LED) {
+               if (!led_patterns[N_STATUS_LED])
+                       led_set_pattern(N_STATUS_LED,
+                               pattern_select(N_STATUS_LED));
        } else {
                led_set_pattern(n, pattern_select(n));
        }