add a FIXME. We should probably not allocate a bookmark object every time

2005-01-07  Marco Pesenti Gritti  <marco@gnome.org>

        * pdf/xpdf/pdf-document.cc:

        add a FIXME. We should probably not allocate
        a bookmark object every time

diff --git a/ChangeLog b/ChangeLog
index ca0222cca8fead5e76f2acd4fdb40361e95d6822..1b3fc2280586609ef8bb2fad9799414c4e4594de 100644 (file)
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,3 +1,10 @@
+2005-01-07  Marco Pesenti Gritti  <marco@gnome.org>
+
+       * pdf/xpdf/pdf-document.cc:
+
+       add a FIXME. We should probably not allocate
+       a bookmark object every time
+
 2005-01-07  Marco Pesenti Gritti  <marco@gnome.org>
 
        * shell/ev-application.c: (ev_application_open),

diff --git a/pdf/xpdf/pdf-document.cc b/pdf/xpdf/pdf-document.cc
index 6e077162c59e138e45eefe1246006e94255171bd..6f137dd926e39c7b82a3225be21461077d67720f 100644 (file)
--- a/pdf/xpdf/pdf-document.cc
+++ b/pdf/xpdf/pdf-document.cc
@@ -740,6 +740,8 @@ pdf_document_bookmarks_begin_read (EvDocumentBookmarks *document_bookmarks)
        return (EvDocumentBookmarksIter *) iter;
 }
 
+/* FIXME This returns a new object every time, probably we should cache it
+   in the iter */
 static EvBookmark *
 pdf_document_bookmarks_get_bookmark (EvDocumentBookmarks      *document_bookmarks,
                                     EvDocumentBookmarksIter  *bookmarks_iter)