]> www.fi.muni.cz Git - evince.git/blobdiff - libview/ev-view.c
Unref document after unreffing pixbuf_cache.
[evince.git] / libview / ev-view.c
index 55caf2ab7afb4198c7e313b0231321dd87225969..735ad1349e48d035c55fa74618994343325c7d23 100644 (file)
@@ -35,6 +35,7 @@
 #include "ev-document-misc.h"
 #include "ev-document-transition.h"
 #include "ev-pixbuf-cache.h"
+#include "ev-page-cache.h"
 #include "ev-transition-animation.h"
 #include "ev-view-marshal.h"
 #include "ev-document-annotations.h"
 
 enum {
        PROP_0,
-       PROP_CONTINUOUS,
-       PROP_DUAL_PAGE,
-       PROP_FULLSCREEN,
        PROP_PRESENTATION,
-       PROP_SIZING_MODE,
-       PROP_ZOOM,
-       PROP_ROTATION,
-       PROP_HAS_SELECTION,
+       PROP_HAS_SELECTION
 };
 
 enum {
@@ -87,8 +82,6 @@ typedef enum {
 #define SCROLL_TIME 150
 
 /*** Scrolling ***/
-static void       scroll_to_current_page                    (EvView *view,
-                                                             GtkOrientation orientation);
 static void       ev_view_set_scroll_adjustments             (GtkLayout          *layout,
                                                              GtkAdjustment      *hadjustment,
                                                              GtkAdjustment      *vadjustment);
@@ -131,7 +124,7 @@ static void       find_page_at_location                      (EvView
                                                              gint               *page,
                                                              gint               *x_offset,
                                                              gint               *y_offset);
-static gboolean  doc_point_to_view_point                    (EvView             *view,
+static void       doc_point_to_view_point                   (EvView             *view,
                                                              int                 page,
                                                              EvPoint            *doc_point,
                                                              GdkPoint           *view_point);
@@ -212,6 +205,9 @@ static void       ev_view_reload_page                        (EvView
                                                              GdkRegion          *region);
 
 /*** Callbacks ***/
+static void       ev_view_change_page                        (EvView             *view,
+                                                             gint                new_page,
+                                                             gboolean            start_transition);
 static void       job_finished_cb                            (EvPixbufCache      *pixbuf_cache,
                                                              GdkRegion          *region,
                                                              EvView             *view);
@@ -479,43 +475,62 @@ ev_view_get_height_to_page (EvView *view,
                *dual_height = (gint)(dh * view->scale + 0.5);
 }
 
-static void
-scroll_to_current_page (EvView *view, GtkOrientation orientation)
+static gint
+ev_view_get_scrollbar_size (EvView        *view,
+                           GtkOrientation orientation)
 {
-       GdkPoint view_point;
-
-       if (view->document == NULL) {
-               return;
-       }
+       GtkWidget *widget = GTK_WIDGET (view);
+       GtkWidget *sb;
+       GtkWidget *swindow = gtk_widget_get_parent (GTK_WIDGET (view));
+       GtkRequisition req;
+       gint spacing;
 
-        doc_point_to_view_point (view, view->current_page, &view->pending_point, &view_point);
+       if (!GTK_IS_SCROLLED_WINDOW (swindow))
+               return 0;
 
        if (orientation == GTK_ORIENTATION_VERTICAL) {
-               view->pending_point.y = 0;
+               if (widget->allocation.height >= widget->requisition.height)
+                       sb = gtk_scrolled_window_get_vscrollbar (GTK_SCROLLED_WINDOW (swindow));
+               else
+                       return 0;
        } else {
-               view->pending_point.x = 0;
+               if (widget->allocation.width >= widget->requisition.width)
+                       sb = gtk_scrolled_window_get_hscrollbar (GTK_SCROLLED_WINDOW (swindow));
+               else
+                       return 0;
        }
 
+       gtk_widget_style_get (swindow, "scrollbar_spacing", &spacing, NULL);
+       gtk_widget_size_request (sb, &req);
+
+       return (orientation == GTK_ORIENTATION_VERTICAL ? req.width : req.height) + spacing;
+}
+
+static void
+scroll_to_point (EvView        *view,
+                gdouble        x,
+                gdouble        y,
+                GtkOrientation orientation)
+{
        if (orientation == GTK_ORIENTATION_VERTICAL) {
                if (view->continuous) {
                        gtk_adjustment_clamp_page (view->vadjustment,
-                                                  view_point.y - view->spacing / 2,
-                                                  view_point.y + view->vadjustment->page_size);
+                                                  y - view->spacing / 2,
+                                                  y + view->vadjustment->page_size);
                } else {
                        gtk_adjustment_set_value (view->vadjustment,
-                                                 CLAMP (view_point.y,
+                                                 CLAMP (y,
                                                  view->vadjustment->lower,
                                                  view->vadjustment->upper -
                                                  view->vadjustment->page_size));
                }
        } else {
                if (view->dual_page) {
-                       gtk_adjustment_clamp_page (view->hadjustment,
-                                                  view_point.x,
-                                                  view_point.x + view->hadjustment->page_size);
+                       gtk_adjustment_clamp_page (view->hadjustment, x,
+                                                  x + view->hadjustment->page_size);
                } else {
                        gtk_adjustment_set_value (view->hadjustment,
-                                                 CLAMP (view_point.x,
+                                                 CLAMP (x,
                                                  view->hadjustment->lower,
                                                  view->hadjustment->upper -
                                                  view->hadjustment->page_size));
@@ -523,6 +538,34 @@ scroll_to_current_page (EvView *view, GtkOrientation orientation)
        }
 }
 
+static void
+ev_view_scroll_to_page_position (EvView *view, GtkOrientation orientation)
+{
+       gdouble x, y;
+
+       if (!view->document)
+               return;
+
+       if ((orientation == GTK_ORIENTATION_VERTICAL && view->pending_point.y == 0) ||
+           (orientation == GTK_ORIENTATION_HORIZONTAL && view->pending_point.x == 0)) {
+               GdkRectangle page_area;
+               GtkBorder    border;
+
+               get_page_extents (view, view->current_page, &page_area, &border);
+               x = page_area.x;
+               y = page_area.y;
+       } else {
+               GdkPoint view_point;
+
+               doc_point_to_view_point (view, view->current_page,
+                                        &view->pending_point, &view_point);
+               x = view_point.x;
+               y = view_point.y;
+       }
+
+       scroll_to_point (view, x, y, orientation);
+}
+
 static void
 view_set_adjustment_values (EvView         *view,
                            GtkOrientation  orientation)
@@ -577,7 +620,7 @@ view_set_adjustment_values (EvView         *view,
                        gtk_adjustment_set_value (adjustment, (int)new_value);
                        break;
                case SCROLL_TO_PAGE_POSITION:
-                       scroll_to_current_page (view, orientation);
+                       ev_view_scroll_to_page_position (view, orientation);
                        break;
                case SCROLL_TO_CENTER:
                        new_value = CLAMP (adjustment->upper * factor - adjustment->page_size * 0.5 + 0.5,
@@ -592,8 +635,6 @@ view_set_adjustment_values (EvView         *view,
 static void
 view_update_range_and_current_page (EvView *view)
 {
-       gint current_page;
-       gint best_current_page = -1;
        gint start = view->start_page;
        gint end = view->end_page;
        
@@ -606,13 +647,14 @@ view_update_range_and_current_page (EvView *view)
                GtkBorder border;
                gboolean found = FALSE;
                gint area_max = -1, area;
-               int i;
+               gint best_current_page = -1;
+               int i, j = 0;
 
                if (!(view->vadjustment && view->hadjustment))
                        return;
 
                current_area.x = view->hadjustment->value;
-               current_area.width = view->hadjustment->upper;
+               current_area.width = view->hadjustment->page_size;
                current_area.y = view->vadjustment->value;
                current_area.height = view->vadjustment->page_size;
 
@@ -635,17 +677,33 @@ view_update_range_and_current_page (EvView *view)
                                }
 
                                view->end_page = i;
+                               j = 0;
                        } else if (found && view->current_page <= view->end_page) {
+                               if (view->dual_page && j < 1) {
+                                       /* In dual mode  we stop searching
+                                        * after two consecutive non-visible pages.
+                                        */
+                                       j++;
+                                       continue;
+                               }
                                break;
                        }
                }
 
+               if (view->pending_scroll == SCROLL_TO_KEEP_POSITION) {
+                       best_current_page = MAX (best_current_page, view->start_page);
+
+                       if (view->current_page != best_current_page) {
+                               view->current_page = best_current_page;
+                               ev_document_model_set_page (view->model, best_current_page);
+                       }
+               }
        } else if (view->dual_page) {
                if (view->current_page % 2 == get_dual_even_left (view)) {
                        view->start_page = view->current_page;
                        if (view->current_page + 1 < ev_document_get_n_pages (view->document))
                                view->end_page = view->start_page + 1;
-                       else 
+                       else
                                view->end_page = view->start_page;
                } else {
                        if (view->current_page < 1)
@@ -659,32 +717,30 @@ view_update_range_and_current_page (EvView *view)
                view->end_page = view->current_page;
        }
 
-       best_current_page = MAX (best_current_page, view->start_page);
-       current_page = ev_document_model_get_page (view->model);
-
-       if ((current_page != best_current_page) && (view->pending_scroll == SCROLL_TO_KEEP_POSITION)) {
-               view->current_page = best_current_page;
-               ev_document_model_set_page (view->model, best_current_page);
-       }
-
        if (start != view->start_page || end != view->end_page) {
                gint i;
 
-               for (i = start; i < view->start_page; i++) {
+               for (i = start; i < view->start_page && start != -1; i++) {
                        hide_annotation_windows (view, i);
                }
 
-               for (i = end; i > view->end_page; i--) {
+               for (i = end; i > view->end_page && end != -1; i--) {
                        hide_annotation_windows (view, i);
                }
        }
 
+       ev_page_cache_set_page_range (view->page_cache,
+                                     view->start_page,
+                                     view->end_page);
        ev_pixbuf_cache_set_page_range (view->pixbuf_cache,
                                        view->start_page,
                                        view->end_page,
                                        view->rotation,
                                        view->scale,
                                        view->selection_info.selections);
+
+       if (ev_pixbuf_cache_get_surface (view->pixbuf_cache, view->current_page))
+           gtk_widget_queue_draw (GTK_WIDGET (view));
 }
 
 static void
@@ -750,6 +806,79 @@ add_scroll_binding_keypad (GtkBindingSet  *binding_set,
                                G_TYPE_BOOLEAN, horizontal);
 }
 
+static gdouble
+compute_scroll_increment (EvView        *view,
+                         GtkScrollType  scroll)
+{
+       GtkWidget *widget = GTK_WIDGET (view);
+       GtkAdjustment *adjustment = view->vadjustment;
+       GdkRegion *text_region, *region;
+       gint page;
+       GdkRectangle rect;
+       EvRectangle doc_rect;
+       GdkRectangle page_area;
+       GtkBorder border;
+       GdkRectangle *recs;
+       gint n_recs;
+       gdouble fraction = 1.0;
+
+       if (scroll != GTK_SCROLL_PAGE_BACKWARD && scroll != GTK_SCROLL_PAGE_FORWARD)
+               return adjustment->page_size;
+
+       page = scroll == GTK_SCROLL_PAGE_BACKWARD ? view->start_page : view->end_page;
+
+       text_region = ev_page_cache_get_text_mapping (view->page_cache, page);
+       if (!text_region || gdk_region_empty (text_region))
+               return adjustment->page_size;
+
+       get_page_extents (view, page, &page_area, &border);
+       rect.x = page_area.x + view->scroll_x;
+       rect.y = view->scroll_y + (scroll == GTK_SCROLL_PAGE_BACKWARD ? 5 : widget->allocation.height - 5);
+       rect.width = page_area.width;
+       rect.height = 1;
+       view_rect_to_doc_rect (view, &rect, &page_area, &doc_rect);
+
+       /* Convert the doc rectangle into a GdkRectangle */
+       rect.x = doc_rect.x1;
+       rect.y = doc_rect.y1;
+       rect.width = doc_rect.x2 - doc_rect.x1;
+       rect.height = MAX (1, doc_rect.y2 - doc_rect.y1);
+       region = gdk_region_rectangle (&rect);
+
+       gdk_region_intersect (region, text_region);
+       gdk_region_get_rectangles (region, &recs, &n_recs);
+       gdk_region_destroy (region);
+       if (n_recs > 0) {
+               EvRenderContext *rc;
+               EvPage  *ev_page;
+
+               ev_page = ev_document_get_page (view->document, page);
+               rc = ev_render_context_new (ev_page, view->rotation, view->scale);
+               g_object_unref (ev_page);
+               /* Get the selection region to know the height of the line */
+               doc_rect.x1 = doc_rect.x2 = recs[0].x + 0.5;
+               doc_rect.y1 = doc_rect.y2 = recs[0].y + 0.5;
+
+               ev_document_doc_mutex_lock ();
+               region = ev_selection_get_selection_region (EV_SELECTION (view->document),
+                                                           rc, EV_SELECTION_STYLE_LINE,
+                                                           &doc_rect);
+               ev_document_doc_mutex_unlock ();
+
+               g_object_unref (rc);
+               g_free (recs);
+               gdk_region_get_rectangles (region, &recs, &n_recs);
+               gdk_region_destroy (region);
+               if (n_recs > 0) {
+                       fraction = 1 - (recs[0].height / adjustment->page_size);
+               }
+               g_free (recs);
+       }
+
+       return adjustment->page_size * fraction;
+
+}
+
 void
 ev_view_scroll (EvView        *view,
                GtkScrollType  scroll,
@@ -780,7 +909,6 @@ ev_view_scroll (EvView        *view,
 
        /* Assign values for increment and vertical adjustment */
        adjustment = horizontal ? view->hadjustment : view->vadjustment;
-       increment = adjustment->page_size * 0.75;
        value = adjustment->value;
 
        /* Assign boolean for first and last page */
@@ -800,6 +928,7 @@ ev_view_scroll (EvView        *view,
                                ev_view_previous_page (view);
                                /* Jump to the top */
                        } else {
+                               increment = compute_scroll_increment (view, GTK_SCROLL_PAGE_BACKWARD);
                                value = MAX (value - increment, adjustment->lower);
                        }
                        break;
@@ -813,6 +942,7 @@ ev_view_scroll (EvView        *view,
                                ev_view_next_page (view);
                        /* Jump to the bottom */
                        } else {
+                               increment = compute_scroll_increment (view, GTK_SCROLL_PAGE_FORWARD);
                                value = MIN (value + increment, adjustment->upper - adjustment->page_size);
                        }
                        break;
@@ -1107,7 +1237,7 @@ view_rect_to_doc_rect (EvView *view,
        doc_rect->y2 = doc_rect->y1 + (double) view_rect->height / view->scale;
 }
 
-static gboolean
+static void
 doc_point_to_view_point (EvView       *view,
                          int           page,
                         EvPoint      *doc_point,
@@ -1138,13 +1268,10 @@ doc_point_to_view_point (EvView       *view,
 
        get_page_extents (view, page, &page_area, &border);
 
-       view_x = x * view->scale;
-       view_y = y * view->scale;
+       view_x = CLAMP (x * view->scale, 0, page_area.width);
+       view_y = CLAMP (y * view->scale, 0, page_area.height);
        view_point->x = view_x + page_area.x;
        view_point->y = view_y + page_area.y;
-
-       return (view_x > 0 && view_x <= page_area.width &&
-               view_y > 0 && view_y <= page_area.height);
 }
 
 static void
@@ -1250,7 +1377,7 @@ location_in_text (EvView  *view,
        if (page == -1)
                return FALSE;
        
-       region = ev_pixbuf_cache_get_text_mapping (view->pixbuf_cache, page);
+       region = ev_page_cache_get_text_mapping (view->page_cache, page);
 
        if (region)
                return gdk_region_point_in (region, x_offset / view->scale, y_offset / view->scale);
@@ -1385,7 +1512,7 @@ ev_view_get_link_at_location (EvView  *view,
        if (!get_doc_point_from_location (view, x, y, &page, &x_new, &y_new))
                return NULL;
 
-       link_mapping = ev_pixbuf_cache_get_link_mapping (view->pixbuf_cache, page);
+       link_mapping = ev_page_cache_get_link_mapping (view->page_cache, page);
 
        if (link_mapping)
                return ev_mapping_list_get_data (link_mapping, x_new, y_new);
@@ -1413,13 +1540,9 @@ goto_fitr_dest (EvView *view, EvLinkDest *dest)
 
        doc_point.x = change_left ? left : 0;
        doc_point.y = change_top ? top : 0;
-       
-       view->current_page = ev_link_dest_get_page (dest);
-       if (change_left || change_top)
-               view->pending_point = doc_point;
-       view->pending_scroll = SCROLL_TO_PAGE_POSITION;
+       view->pending_point = doc_point;
 
-       gtk_widget_queue_resize (GTK_WIDGET (view));
+       ev_view_change_page (view, ev_link_dest_get_page (dest), TRUE);
 }
 
 static void
@@ -1445,12 +1568,9 @@ goto_fitv_dest (EvView *view, EvLinkDest *dest)
        ev_document_model_set_sizing_mode (view->model, EV_SIZING_FREE);
        ev_document_model_set_scale (view->model, zoom);
 
-       view->current_page = page;
-       if (change_left)
-               view->pending_point = doc_point;
-       view->pending_scroll = SCROLL_TO_PAGE_POSITION;
+       view->pending_point = doc_point;
 
-       gtk_widget_queue_resize (GTK_WIDGET (view));
+       ev_view_change_page (view, page, TRUE);
 }
 
 static void
@@ -1477,12 +1597,9 @@ goto_fith_dest (EvView *view, EvLinkDest *dest)
        ev_document_model_set_sizing_mode (view->model, EV_SIZING_FIT_WIDTH);
        ev_document_model_set_scale (view->model, zoom);
 
-       view->current_page = page;
-       if (change_top)
-               view->pending_point = doc_point;
-       view->pending_scroll = SCROLL_TO_PAGE_POSITION;
+       view->pending_point = doc_point;
 
-       gtk_widget_queue_resize (GTK_WIDGET (view));
+       ev_view_change_page (view, page, TRUE);
 }
 
 static void
@@ -1502,10 +1619,7 @@ goto_fit_dest (EvView *view, EvLinkDest *dest)
        ev_document_model_set_sizing_mode (view->model, EV_SIZING_BEST_FIT);
        ev_document_model_set_scale (view->model, zoom);
 
-       view->current_page = page;
-       view->pending_scroll = SCROLL_TO_PAGE_POSITION;
-
-       gtk_widget_queue_resize (GTK_WIDGET (view));
+       ev_view_change_page (view, page, TRUE);
 }
 
 static void
@@ -1529,13 +1643,9 @@ goto_xyz_dest (EvView *view, EvLinkDest *dest)
 
        doc_point.x = change_left ? left : 0;
        doc_point.y = change_top ? top : 0;
+       view->pending_point = doc_point;
 
-       view->current_page = page;
-       if (change_left || change_top)
-               view->pending_point = doc_point;
-       view->pending_scroll = SCROLL_TO_PAGE_POSITION;
-
-       gtk_widget_queue_resize (GTK_WIDGET (view));
+       ev_view_change_page (view, page, TRUE);
 }
 
 static void
@@ -1820,7 +1930,7 @@ ev_view_get_image_at_location (EvView  *view,
        if (!get_doc_point_from_location (view, x, y, &page, &x_new, &y_new))
                return NULL;
 
-       image_mapping = ev_pixbuf_cache_get_image_mapping (view->pixbuf_cache, page);
+       image_mapping = ev_page_cache_get_image_mapping (view->page_cache, page);
 
        if (image_mapping)
                return ev_mapping_list_get_data (image_mapping, x_new, y_new);
@@ -1844,7 +1954,7 @@ ev_view_get_form_field_at_location (EvView  *view,
        if (!get_doc_point_from_location (view, x, y, &page, &x_new, &y_new))
                return NULL;
 
-       forms_mapping = ev_pixbuf_cache_get_form_field_mapping (view->pixbuf_cache, page);
+       forms_mapping = ev_page_cache_get_form_field_mapping (view->page_cache, page);
 
        if (forms_mapping)
                return ev_mapping_list_get_data (forms_mapping, x_new, y_new);
@@ -1859,8 +1969,8 @@ ev_view_form_field_get_region (EvView      *view,
        GdkRectangle view_area;
        GList       *forms_mapping;
 
-       forms_mapping = ev_pixbuf_cache_get_form_field_mapping (view->pixbuf_cache,
-                                                               field->page->index);
+       forms_mapping = ev_page_cache_get_form_field_mapping (view->page_cache,
+                                                             field->page->index);
        ev_view_get_area_from_mapping (view, field->page->index,
                                       forms_mapping,
                                       field, &view_area);
@@ -1911,8 +2021,8 @@ ev_view_form_field_button_create_widget (EvView      *view,
                        /* For radio buttons and checkbox buttons that are in a set
                         * we need to update also the region for the current selected item
                         */
-                       forms_mapping = ev_pixbuf_cache_get_form_field_mapping (view->pixbuf_cache,
-                                                                               field->page->index);
+                       forms_mapping = ev_page_cache_get_form_field_mapping (view->page_cache,
+                                                                             field->page->index);
                        for (l = forms_mapping; l; l = g_list_next (l)) {
                                EvFormField *button = ((EvMapping *)(l->data))->data;
                                GdkRegion   *button_region;
@@ -2295,7 +2405,8 @@ ev_view_handle_form_field (EvView      *view,
                                g_object_ref (field),
                                (GDestroyNotify)g_object_unref);
 
-       form_field_mapping = ev_pixbuf_cache_get_form_field_mapping (view->pixbuf_cache, field->page->index);
+       form_field_mapping = ev_page_cache_get_form_field_mapping (view->page_cache,
+                                                                  field->page->index);
        ev_view_get_area_from_mapping (view, field->page->index,
                                       form_field_mapping,
                                       field, &view_area);
@@ -2519,7 +2630,7 @@ show_annotation_windows (EvView *view,
 
        parent = GTK_WINDOW (gtk_widget_get_toplevel (GTK_WIDGET (view)));
 
-       annots = ev_pixbuf_cache_get_annots_mapping (view->pixbuf_cache, page);
+       annots = ev_page_cache_get_annot_mapping (view->page_cache, page);
 
        for (l = annots; l && l->data; l = g_list_next (l)) {
                EvAnnotation      *annot;
@@ -2584,7 +2695,7 @@ hide_annotation_windows (EvView *view,
 {
        GList *annots, *l;
 
-       annots = ev_pixbuf_cache_get_annots_mapping (view->pixbuf_cache, page);
+       annots = ev_page_cache_get_annot_mapping (view->page_cache, page);
 
        for (l = annots; l && l->data; l = g_list_next (l)) {
                EvAnnotation *annot;
@@ -2616,7 +2727,7 @@ ev_view_get_annotation_at_location (EvView  *view,
        if (!get_doc_point_from_location (view, x, y, &page, &x_new, &y_new))
                return NULL;
 
-       annotations_mapping = ev_pixbuf_cache_get_annots_mapping (view->pixbuf_cache, page);
+       annotations_mapping = ev_page_cache_get_annot_mapping (view->page_cache, page);
 
        if (annotations_mapping)
                return ev_mapping_list_get_data (annotations_mapping, x_new, y_new);
@@ -2628,7 +2739,8 @@ static void
 ev_view_handle_annotation (EvView       *view,
                           EvAnnotation *annot,
                           gdouble       x,
-                          gdouble       y)
+                          gdouble       y,
+                          guint32       timestamp)
 {
        if (EV_IS_ANNOTATION_MARKUP (annot)) {
                GtkWidget *window;
@@ -2645,6 +2757,24 @@ ev_view_handle_annotation (EvView       *view,
                        }
                }
        }
+
+       if (EV_IS_ANNOTATION_ATTACHMENT (annot)) {
+               EvAttachment *attachment = EV_ANNOTATION_ATTACHMENT (annot)->attachment;
+
+               if (attachment) {
+                       GError *error = NULL;
+
+                       ev_attachment_open (attachment,
+                                           gtk_widget_get_screen (GTK_WIDGET (view)),
+                                           timestamp,
+                                           &error);
+
+                       if (error) {
+                               g_warning ("%s", error->message);
+                               g_error_free (error);
+                       }
+               }
+       }
 }
 
 /*** GtkWidget implementation ***/
@@ -2653,25 +2783,28 @@ static void
 ev_view_size_request_continuous_dual_page (EvView         *view,
                                           GtkRequisition *requisition)
 {
-       int max_width;
        gint n_pages;
-       GtkBorder border;
-
-       ev_view_get_max_page_size (view, &max_width, NULL);
-       compute_border (view, max_width, max_width, &border);
 
        n_pages = ev_document_get_n_pages (view->document) + 1;
-
-       requisition->width = (max_width + border.left + border.right) * 2 + (view->spacing * 3);
        get_page_y_offset (view, n_pages, &requisition->height);
 
-       if (view->sizing_mode == EV_SIZING_FIT_WIDTH) {
-               requisition->width = 1;
-       } else if (view->sizing_mode == EV_SIZING_BEST_FIT) {
-               requisition->width = 1;
-               /* FIXME: This could actually be set on one page docs or docs
-                * with a strange aspect ratio. */
-               /* requisition->height = 1;*/
+       switch (view->sizing_mode) {
+               case EV_SIZING_FIT_WIDTH:
+               case EV_SIZING_BEST_FIT:
+                       requisition->width = 1;
+
+                       break;
+               case EV_SIZING_FREE: {
+                       gint max_width;
+                       GtkBorder border;
+
+                       ev_view_get_max_page_size (view, &max_width, NULL);
+                       compute_border (view, max_width, max_width, &border);
+                       requisition->width = (max_width + border.left + border.right) * 2 + (view->spacing * 3);
+               }
+                       break;
+               default:
+                       g_assert_not_reached ();
        }
 }
 
@@ -2679,24 +2812,28 @@ static void
 ev_view_size_request_continuous (EvView         *view,
                                 GtkRequisition *requisition)
 {
-       int max_width;
-       int n_pages;
-       GtkBorder border;
+       gint n_pages;
 
-       ev_view_get_max_page_size (view, &max_width, NULL);
        n_pages = ev_document_get_n_pages (view->document);
-       compute_border (view, max_width, max_width, &border);
-
-       requisition->width = max_width + (view->spacing * 2) + border.left + border.right;
        get_page_y_offset (view, n_pages, &requisition->height);
 
-       if (view->sizing_mode == EV_SIZING_FIT_WIDTH) {
-               requisition->width = 1;
-       } else if (view->sizing_mode == EV_SIZING_BEST_FIT) {
-               requisition->width = 1;
-               /* FIXME: This could actually be set on one page docs or docs
-                * with a strange aspect ratio. */
-               /* requisition->height = 1;*/
+       switch (view->sizing_mode) {
+               case EV_SIZING_FIT_WIDTH:
+               case EV_SIZING_BEST_FIT:
+                       requisition->width = 1;
+
+                       break;
+               case EV_SIZING_FREE: {
+                       gint max_width;
+                       GtkBorder border;
+
+                       ev_view_get_max_page_size (view, &max_width, NULL);
+                       compute_border (view, max_width, max_width, &border);
+                       requisition->width = max_width + (view->spacing * 2) + border.left + border.right;
+               }
+                       break;
+               default:
+                       g_assert_not_reached ();
        }
 }
 
@@ -2707,6 +2844,13 @@ ev_view_size_request_dual_page (EvView         *view,
        GtkBorder border;
        gint width, height;
 
+       if (view->sizing_mode == EV_SIZING_BEST_FIT) {
+               requisition->width = 1;
+               requisition->height = 1;
+
+               return;
+       }
+
        /* Find the largest of the two. */
        ev_view_get_page_size (view,
                               view->current_page,
@@ -2723,17 +2867,9 @@ ev_view_size_request_dual_page (EvView         *view,
        }
        compute_border (view, width, height, &border);
 
-       requisition->width = ((width + border.left + border.right) * 2) +
-               (view->spacing * 3);
-       requisition->height = (height + border.top + border.bottom) +
-               (view->spacing * 2);
-
-       if (view->sizing_mode == EV_SIZING_FIT_WIDTH) {
-               requisition->width = 1;
-       } else if (view->sizing_mode == EV_SIZING_BEST_FIT) {
-               requisition->width = 1;
-               requisition->height = 1;
-       }
+       requisition->width = view->sizing_mode == EV_SIZING_FIT_WIDTH ? 1 :
+               ((width + border.left + border.right) * 2) + (view->spacing * 3);
+       requisition->height = (height + border.top + border.bottom) + (view->spacing * 2);
 }
 
 static void
@@ -2743,19 +2879,19 @@ ev_view_size_request_single_page (EvView         *view,
        GtkBorder border;
        gint width, height;
 
+       if (view->sizing_mode == EV_SIZING_BEST_FIT) {
+               requisition->width = 1;
+               requisition->height = 1;
+
+               return;
+       }
+
        ev_view_get_page_size (view, view->current_page, &width, &height);
        compute_border (view, width, height, &border);
 
-       requisition->width = width + border.left + border.right + (2 * view->spacing);
+       requisition->width = view->sizing_mode == EV_SIZING_FIT_WIDTH ? 1 :
+               width + border.left + border.right + (2 * view->spacing);
        requisition->height = height + border.top + border.bottom + (2 * view->spacing);
-
-       if (view->sizing_mode == EV_SIZING_FIT_WIDTH) {
-               requisition->width = 1;
-               requisition->height = height + border.top + border.bottom + (2 * view->spacing);
-       } else if (view->sizing_mode == EV_SIZING_BEST_FIT) {
-               requisition->width = 1;
-               requisition->height = 1;
-       }
 }
 
 static void
@@ -2812,6 +2948,8 @@ ev_view_size_allocate (GtkWidget      *widget,
 
        view->pending_scroll = SCROLL_TO_KEEP_POSITION;
        view->pending_resize = FALSE;
+       view->pending_point.x = 0;
+       view->pending_point.y = 0;
 
        children = gtk_container_get_children (GTK_CONTAINER (widget));
        for (l = children; l && l->data; l = g_list_next (l)) {
@@ -2826,8 +2964,8 @@ ev_view_size_allocate (GtkWidget      *widget,
                if (!field)
                        continue;
 
-               form_field_mapping = ev_pixbuf_cache_get_form_field_mapping (view->pixbuf_cache,
-                                                                            field->page->index);
+               form_field_mapping = ev_page_cache_get_form_field_mapping (view->page_cache,
+                                                                          field->page->index);
                ev_view_get_area_from_mapping (view, field->page->index,
                                               form_field_mapping,
                                               field, &view_area);
@@ -2914,8 +3052,7 @@ ev_view_scroll_event (GtkWidget *widget, GdkEventScroll *event)
        state = event->state & gtk_accelerator_get_default_mod_mask ();
 
        if (state == GDK_CONTROL_MASK && view->presentation == FALSE) {
-               ev_view_set_sizing_mode (view, EV_SIZING_FREE);
-
+               ev_document_model_set_sizing_mode (view->model, EV_SIZING_FREE);
                if (event->direction == GDK_SCROLL_UP ||
                    event->direction == GDK_SCROLL_LEFT) {
                        if (ev_view_can_zoom_in (view)) {
@@ -3082,7 +3219,7 @@ ev_view_expose_event (GtkWidget      *widget,
                return FALSE;
 
        cr = gdk_cairo_create (view->layout.bin_window);
-       
+
        for (i = view->start_page; i >= 0 && i <= view->end_page; i++) {
                GdkRectangle page_area;
                GtkBorder border;
@@ -3115,8 +3252,9 @@ ev_view_do_popup_menu (EvView *view,
                       gdouble x,
                       gdouble y)
 {
-       EvLink  *link;
-       EvImage *image;
+       EvLink       *link;
+       EvImage      *image;
+       EvAnnotation *annot;
 
        image = ev_view_get_image_at_location (view, x, y);
        if (image) {
@@ -3130,6 +3268,12 @@ ev_view_do_popup_menu (EvView *view,
                return TRUE;
        }
 
+       annot = ev_view_get_annotation_at_location (view, x, y);
+       if (annot) {
+               g_signal_emit (view, signals[SIGNAL_POPUP_MENU], 0, annot);
+               return TRUE;
+       }
+
        g_signal_emit (view, signals[SIGNAL_POPUP_MENU], 0, NULL);
 
        return TRUE;
@@ -3160,7 +3304,7 @@ get_link_area (EvView       *view,
        
        find_page_at_location (view, x, y, &page, &x_offset, &y_offset);
        
-       link_mapping = ev_pixbuf_cache_get_link_mapping (view->pixbuf_cache, page);
+       link_mapping = ev_page_cache_get_link_mapping (view->page_cache, page);
        ev_view_get_area_from_mapping (view, page,
                                       link_mapping,
                                       link, area);
@@ -3173,7 +3317,7 @@ get_annot_area (EvView       *view,
               EvAnnotation *annot,
               GdkRectangle *area)
 {
-       GList *annots_mapping;
+       GList *annot_mapping;
        gint   page;
        gint   x_offset = 0, y_offset = 0;
 
@@ -3182,9 +3326,9 @@ get_annot_area (EvView       *view,
 
        find_page_at_location (view, x, y, &page, &x_offset, &y_offset);
 
-       annots_mapping = ev_pixbuf_cache_get_annots_mapping (view->pixbuf_cache, page);
+       annot_mapping = ev_page_cache_get_annot_mapping (view->page_cache, page);
        ev_view_get_area_from_mapping (view, page,
-                                      annots_mapping,
+                                      annot_mapping,
                                       annot, area);
 }
 
@@ -3305,7 +3449,7 @@ ev_view_button_press_event (GtkWidget      *widget,
 
                                gtk_widget_queue_draw (widget);
                        } else if ((annot = ev_view_get_annotation_at_location (view, event->x, event->y))) {
-                               ev_view_handle_annotation (view, annot, event->x, event->y);
+                               ev_view_handle_annotation (view, annot, event->x, event->y, event->time);
                        } else if ((field = ev_view_get_form_field_at_location (view, event->x, event->y))) {
                                ev_view_remove_all (view);
                                ev_view_handle_form_field (view, field, event->x, event->y);
@@ -4410,14 +4554,19 @@ ev_view_destroy (GtkObject *object)
                view->model = NULL;
        }
 
+       if (view->pixbuf_cache) {
+               g_object_unref (view->pixbuf_cache);
+               view->pixbuf_cache = NULL;
+       }
+
        if (view->document) {
                g_object_unref (view->document);
                view->document = NULL;
        }
 
-       if (view->pixbuf_cache) {
-               g_object_unref (view->pixbuf_cache);
-               view->pixbuf_cache = NULL;
+       if (view->page_cache) {
+               g_object_unref (view->page_cache);
+               view->page_cache = NULL;
        }
 
        if (view->goto_window) {
@@ -4474,27 +4623,9 @@ ev_view_set_property (GObject      *object,
        EvView *view = EV_VIEW (object);
 
        switch (prop_id) {
-               case PROP_CONTINUOUS:
-                       ev_view_set_continuous (view, g_value_get_boolean (value));
-                       break;
-               case PROP_DUAL_PAGE:
-                       ev_view_set_dual_page (view, g_value_get_boolean (value));
-                       break;
-               case PROP_FULLSCREEN:
-                       ev_view_set_fullscreen (view, g_value_get_boolean (value));
-                       break;
                case PROP_PRESENTATION:
                        ev_view_set_presentation (view, g_value_get_boolean (value));
                        break;
-               case PROP_SIZING_MODE:
-                       ev_view_set_sizing_mode (view, g_value_get_enum (value));
-                       break;
-               case PROP_ZOOM:
-                       ev_view_set_zoom (view, g_value_get_double (value));
-                       break;
-               case PROP_ROTATION:
-                       ev_view_set_rotation (view, g_value_get_int (value));
-                       break;
                default:
                        G_OBJECT_WARN_INVALID_PROPERTY_ID (object, prop_id, pspec);
        }
@@ -4540,27 +4671,9 @@ ev_view_get_property (GObject *object,
        EvView *view = EV_VIEW (object);
 
        switch (prop_id) {
-               case PROP_CONTINUOUS:
-                       g_value_set_boolean (value, view->continuous);
-                       break;
-               case PROP_DUAL_PAGE:
-                       g_value_set_boolean (value, view->dual_page);
-                       break;
-               case PROP_FULLSCREEN:
-                       g_value_set_boolean (value, view->fullscreen);
-                       break;
                case PROP_PRESENTATION:
                        g_value_set_boolean (value, view->presentation);
                        break;
-               case PROP_SIZING_MODE:
-                       g_value_set_enum (value, view->sizing_mode);
-                       break;
-               case PROP_ZOOM:
-                       g_value_set_double (value, view->scale);
-                       break;
-               case PROP_ROTATION:
-                       g_value_set_int (value, view->rotation);
-                       break;
                case PROP_HAS_SELECTION:
                        g_value_set_boolean (value,
                                             view->selection_info.selections != NULL);
@@ -4644,28 +4757,6 @@ ev_view_class_init (EvViewClass *class)
                         G_TYPE_OBJECT);
 
 
-       g_object_class_install_property (object_class,
-                                        PROP_CONTINUOUS,
-                                        g_param_spec_boolean ("continuous",
-                                                              "Continuous",
-                                                              "Continuous scrolling mode",
-                                                              TRUE,
-                                                              G_PARAM_READWRITE));
-
-       g_object_class_install_property (object_class,
-                                        PROP_DUAL_PAGE,
-                                        g_param_spec_boolean ("dual-page",
-                                                              "Dual Page",
-                                                              "Two pages visible at once",
-                                                              FALSE,
-                                                              G_PARAM_READWRITE));
-       g_object_class_install_property (object_class,
-                                        PROP_FULLSCREEN,
-                                        g_param_spec_boolean ("fullscreen",
-                                                              "Full Screen",
-                                                              "Draw page in a fullscreen fashion",
-                                                              FALSE,
-                                                              G_PARAM_READWRITE));
        g_object_class_install_property (object_class,
                                         PROP_PRESENTATION,
                                         g_param_spec_boolean ("presentation",
@@ -4673,35 +4764,6 @@ ev_view_class_init (EvViewClass *class)
                                                               "Draw page in presentation mode",
                                                               TRUE,
                                                               G_PARAM_READWRITE));
-
-       g_object_class_install_property (object_class,
-                                        PROP_SIZING_MODE,
-                                        g_param_spec_enum ("sizing-mode",
-                                                           "Sizing Mode",
-                                                           "Sizing Mode",
-                                                           EV_TYPE_SIZING_MODE,
-                                                           EV_SIZING_FIT_WIDTH,
-                                                           G_PARAM_READWRITE));
-
-       g_object_class_install_property (object_class,
-                                        PROP_ZOOM,
-                                        g_param_spec_double ("zoom",
-                                                             "Zoom factor",
-                                                             "Zoom factor",
-                                                             0,
-                                                             G_MAXDOUBLE,
-                                                             1.0,
-                                                             G_PARAM_READWRITE));
-       g_object_class_install_property (object_class,
-                                        PROP_ROTATION,
-                                        g_param_spec_double ("rotation",
-                                                             "Rotation",
-                                                             "Rotation",
-                                                             0,
-                                                             360,
-                                                             0,
-                                                             G_PARAM_READWRITE));
-
        g_object_class_install_property (object_class,
                                         PROP_HAS_SELECTION,
                                         g_param_spec_boolean ("has-selection",
@@ -4958,8 +5020,13 @@ ev_view_new (void)
 static void
 setup_caches (EvView *view)
 {
+       gboolean inverted_colors;
+
        view->height_to_page_cache = ev_view_get_height_to_page_cache (view);
        view->pixbuf_cache = ev_pixbuf_cache_new (GTK_WIDGET (view), view->document);
+       view->page_cache = ev_page_cache_new (view->document);
+       inverted_colors = ev_document_model_get_inverted_colors (view->model);
+       ev_pixbuf_cache_set_inverted_colors (view->pixbuf_cache, inverted_colors);
        g_signal_connect (view->pixbuf_cache, "job-finished", G_CALLBACK (job_finished_cb), view);
 }
 
@@ -4970,6 +5037,11 @@ clear_caches (EvView *view)
                g_object_unref (view->pixbuf_cache);
                view->pixbuf_cache = NULL;
        }
+
+       if (view->page_cache) {
+               g_object_unref (view->page_cache);
+               view->page_cache = NULL;
+       }
 }
 
 void
@@ -5063,6 +5135,8 @@ ev_view_document_changed_cb (EvDocumentModel *model,
        view->loading = FALSE;
 
        if (document != view->document) {
+               gint current_page;
+
                clear_caches (view);
 
                if (view->document) {
@@ -5077,9 +5151,13 @@ ev_view_document_changed_cb (EvDocumentModel *model,
                        setup_caches (view);
                 }
 
-               ev_view_change_page (view,
-                                    ev_document_model_get_page (model),
-                                    TRUE);
+               current_page = ev_document_model_get_page (model);
+               if (view->current_page != current_page) {
+                       ev_view_change_page (view, current_page, TRUE);
+               } else {
+                       view->pending_scroll = SCROLL_TO_KEEP_POSITION;
+                       gtk_widget_queue_resize (GTK_WIDGET (view));
+               }
        }
 }
 
@@ -5090,17 +5168,35 @@ ev_view_rotation_changed_cb (EvDocumentModel *model,
 {
        gint rotation = ev_document_model_get_rotation (model);
 
-       ev_view_set_rotation (view, rotation);
+       view->rotation = rotation;
 
        if (view->pixbuf_cache) {
                ev_pixbuf_cache_clear (view->pixbuf_cache);
+               if (!ev_document_is_page_size_uniform (view->document))
+                       view->pending_scroll = SCROLL_TO_PAGE_POSITION;
                gtk_widget_queue_resize (GTK_WIDGET (view));
        }
 
+       ev_view_remove_all (view);
+
        if (rotation != 0)
                clear_selection (view);
 }
 
+static void
+ev_view_inverted_colors_changed_cb (EvDocumentModel *model,
+                                   GParamSpec      *pspec,
+                                   EvView          *view)
+{
+       if (view->pixbuf_cache) {
+               gboolean inverted_colors;
+
+               inverted_colors = ev_document_model_get_inverted_colors (model);
+               ev_pixbuf_cache_set_inverted_colors (view->pixbuf_cache, inverted_colors);
+               gtk_widget_queue_draw (GTK_WIDGET (view));
+       }
+}
+
 static void
 ev_view_sizing_mode_changed_cb (EvDocumentModel *model,
                                GParamSpec      *pspec,
@@ -5108,8 +5204,7 @@ ev_view_sizing_mode_changed_cb (EvDocumentModel *model,
 {
        EvSizingMode mode = ev_document_model_get_sizing_mode (model);
 
-       ev_view_set_sizing_mode (view, mode);
-
+       view->sizing_mode = mode;
        if (mode != EV_SIZING_FREE)
                gtk_widget_queue_resize (GTK_WIDGET (view));
 }
@@ -5130,10 +5225,11 @@ ev_view_scale_changed_cb (EvDocumentModel *model,
                view->loading_text = NULL;
        }
 
-       ev_view_set_zoom (view, scale);
+       view->scale = scale;
 
        view->pending_resize = TRUE;
-       gtk_widget_queue_resize (GTK_WIDGET (view));
+       if (view->sizing_mode == EV_SIZING_FREE)
+               gtk_widget_queue_resize (GTK_WIDGET (view));
 }
 
 static void
@@ -5143,7 +5239,7 @@ ev_view_continuous_changed_cb (EvDocumentModel *model,
 {
        gboolean continuous = ev_document_model_get_continuous (model);
 
-       ev_view_set_continuous (view, continuous);
+       view->continuous = continuous;
        view->pending_scroll = SCROLL_TO_PAGE_POSITION;
        gtk_widget_queue_resize (GTK_WIDGET (view));
 }
@@ -5155,7 +5251,7 @@ ev_view_dual_page_changed_cb (EvDocumentModel *model,
 {
        gboolean dual_page = ev_document_model_get_dual_page (model);
 
-       ev_view_set_dual_page (view, dual_page);
+       view->dual_page = dual_page;
        view->pending_scroll = SCROLL_TO_PAGE_POSITION;
        /* FIXME: if we're keeping the pixbuf cache around, we should extend the
         * preload_cache_size to be 2 if dual_page is set.
@@ -5170,7 +5266,7 @@ ev_view_fullscreen_changed_cb (EvDocumentModel *model,
 {
        gboolean fullscreen = ev_document_model_get_fullscreen (model);
 
-       ev_view_set_fullscreen (view, fullscreen);
+       view->fullscreen = fullscreen;
        gtk_widget_queue_resize (GTK_WIDGET (view));
 }
 
@@ -5200,6 +5296,9 @@ ev_view_set_model (EvView          *view,
        g_signal_connect (view->model, "notify::rotation",
                          G_CALLBACK (ev_view_rotation_changed_cb),
                          view);
+       g_signal_connect (view->model, "notify::inverted-colors",
+                         G_CALLBACK (ev_view_inverted_colors_changed_cb),
+                         view);
        g_signal_connect (view->model, "notify::sizing-mode",
                          G_CALLBACK (ev_view_sizing_mode_changed_cb),
                          view);
@@ -5239,80 +5338,6 @@ ev_view_reload (EvView *view)
        view_update_range_and_current_page (view);
 }
 
-/*** Zoom and sizing mode ***/
-
-void
-ev_view_set_zoom (EvView   *view,
-                 double    scale)
-{
-       view->scale = scale;
-
-       g_object_notify (G_OBJECT (view), "zoom");
-}
-
-double
-ev_view_get_zoom (EvView *view)
-{
-       return view->scale;
-}
-
-gboolean
-ev_view_get_continuous (EvView *view)
-{
-       g_return_val_if_fail (EV_IS_VIEW (view), FALSE);
-
-       return view->continuous;
-}
-
-void
-ev_view_set_continuous (EvView   *view,
-                       gboolean  continuous)
-{
-       g_return_if_fail (EV_IS_VIEW (view));
-
-       view->continuous = continuous;
-
-       g_object_notify (G_OBJECT (view), "continuous");
-}
-
-gboolean
-ev_view_get_dual_page (EvView *view)
-{
-       g_return_val_if_fail (EV_IS_VIEW (view), FALSE);
-
-       return view->dual_page;
-}
-
-void
-ev_view_set_dual_page (EvView   *view,
-                      gboolean  dual_page)
-{
-       g_return_if_fail (EV_IS_VIEW (view));
-
-       view->dual_page = dual_page;
-
-       g_object_notify (G_OBJECT (view), "dual-page");
-}
-
-void
-ev_view_set_fullscreen (EvView   *view,
-                        gboolean  fullscreen)
-{
-       g_return_if_fail (EV_IS_VIEW (view));
-
-       view->fullscreen = fullscreen;
-
-       g_object_notify (G_OBJECT (view), "fullscreen");
-}
-
-gboolean
-ev_view_get_fullscreen (EvView *view)
-{
-       g_return_val_if_fail (EV_IS_VIEW (view), FALSE);
-
-       return view->fullscreen;
-}
-
 void
 ev_view_set_presentation (EvView   *view,
                          gboolean  presentation)
@@ -5333,7 +5358,7 @@ ev_view_set_presentation (EvView   *view,
        if (presentation) {
                view->sizing_mode_saved = view->sizing_mode;
                view->scale_saved = view->scale;
-               ev_view_set_sizing_mode (view, EV_SIZING_BEST_FIT);
+               ev_document_model_set_sizing_mode (view->model, EV_SIZING_BEST_FIT);
        } else {
                ev_document_model_set_sizing_mode (view->model, view->sizing_mode_saved);
                ev_document_model_set_scale (view->model, view->scale_saved);
@@ -5408,22 +5433,7 @@ ev_view_presentation_transition_start (EvView *view)
        }
 }
 
-void
-ev_view_set_sizing_mode (EvView       *view,
-                        EvSizingMode  sizing_mode)
-{
-       view->sizing_mode = sizing_mode;
-
-       g_object_notify (G_OBJECT (view), "sizing-mode");
-}
-
-EvSizingMode
-ev_view_get_sizing_mode (EvView *view)
-{
-       g_return_val_if_fail (EV_IS_VIEW (view), EV_SIZING_FREE);
-
-       return view->sizing_mode;
-}
+/*** Zoom and sizing mode ***/
 
 gboolean
 ev_view_can_zoom_in (EvView *view)
@@ -5467,34 +5477,13 @@ ev_view_zoom_out (EvView *view)
        ev_document_model_set_scale (view->model, scale);
 }
 
-void
-ev_view_set_rotation (EvView *view, int rotation)
-{
-       view->rotation = rotation;
-
-       g_object_notify (G_OBJECT (view), "rotation");
-}
-
-int
-ev_view_get_rotation (EvView *view)
-{
-       return view->rotation;
-}
-
 static double
 zoom_for_size_fit_width (gdouble doc_width,
                         gdouble doc_height,
                         int     target_width,
                         int     target_height)
 {
-       double scale;
-
-       scale = (double)target_width / doc_width;
-
-       if (doc_height * scale > target_height)
-               scale = (double)target_width / doc_width;
-
-       return scale;
+       return (double)target_width / doc_width;
 }
 
 static double
@@ -5503,14 +5492,7 @@ zoom_for_size_fit_height (gdouble doc_width,
                          int     target_width,
                          int     target_height)
 {
-       double scale;
-
-       scale = (double)target_height / doc_height;
-
-       if (doc_width * scale > target_width)
-               scale = (double)target_height / doc_height;
-
-       return scale;
+       return (double)target_height / doc_height;
 }
 
 static double
@@ -5525,11 +5507,6 @@ zoom_for_size_best_fit (gdouble doc_width,
        w_scale = (double)target_width / doc_width;
        h_scale = (double)target_height / doc_height;
 
-       if (doc_height * w_scale > target_height)
-               w_scale = (double)target_width / doc_width;
-       if (doc_width * h_scale > target_width)
-               h_scale = (double)target_height / doc_height;
-
        return MIN (w_scale, h_scale);
 }
 
@@ -5571,9 +5548,12 @@ ev_view_zoom_for_size_continuous_and_dual_page (EvView *view,
        width -= (2 * (border.left + border.right) + 3 * view->spacing);
        height -= (border.top + border.bottom + 2 * view->spacing - 1);
 
-       if (view->sizing_mode == EV_SIZING_FIT_WIDTH)
-               scale = zoom_for_size_fit_width (doc_width, doc_height, width, height);
-       else if (view->sizing_mode == EV_SIZING_BEST_FIT)
+       if (view->sizing_mode == EV_SIZING_FIT_WIDTH) {
+               gint sb_size;
+
+               sb_size = ev_view_get_scrollbar_size (view, GTK_ORIENTATION_VERTICAL);
+               scale = zoom_for_size_fit_width (doc_width, doc_height, width - sb_size, height);
+       } else if (view->sizing_mode == EV_SIZING_BEST_FIT)
                scale = zoom_for_size_best_fit (doc_width, doc_height, width, height);
        else
                g_assert_not_reached ();
@@ -5604,9 +5584,12 @@ ev_view_zoom_for_size_continuous (EvView *view,
        width -= (border.left + border.right + 2 * view->spacing);
        height -= (border.top + border.bottom + 2 * view->spacing - 1);
 
-       if (view->sizing_mode == EV_SIZING_FIT_WIDTH)
-               scale = zoom_for_size_fit_width (doc_width, doc_height, width, height);
-       else if (view->sizing_mode == EV_SIZING_BEST_FIT)
+       if (view->sizing_mode == EV_SIZING_FIT_WIDTH) {
+               gint sb_size;
+
+               sb_size = ev_view_get_scrollbar_size (view, GTK_ORIENTATION_VERTICAL);
+               scale = zoom_for_size_fit_width (doc_width, doc_height, width - sb_size, height);
+       } else if (view->sizing_mode == EV_SIZING_BEST_FIT)
                scale = zoom_for_size_best_fit (doc_width, doc_height, width, height);
        else
                g_assert_not_reached ();
@@ -5643,9 +5626,12 @@ ev_view_zoom_for_size_dual_page (EvView *view,
        width -= ((border.left + border.right)* 2 + 3 * view->spacing);
        height -= (border.top + border.bottom + 2 * view->spacing);
 
-       if (view->sizing_mode == EV_SIZING_FIT_WIDTH)
-               scale = zoom_for_size_fit_width (doc_width, doc_height, width, height);
-       else if (view->sizing_mode == EV_SIZING_BEST_FIT)
+       if (view->sizing_mode == EV_SIZING_FIT_WIDTH) {
+               gint sb_size;
+
+               sb_size = ev_view_get_scrollbar_size (view, GTK_ORIENTATION_VERTICAL);
+               scale = zoom_for_size_fit_width (doc_width, doc_height, width - sb_size, height);
+       } else if (view->sizing_mode == EV_SIZING_BEST_FIT)
                scale = zoom_for_size_best_fit (doc_width, doc_height, width, height);
        else
                g_assert_not_reached ();
@@ -5670,9 +5656,12 @@ ev_view_zoom_for_size_single_page (EvView *view,
        width -= (border.left + border.right + 2 * view->spacing);
        height -= (border.top + border.bottom + 2 * view->spacing);
 
-       if (view->sizing_mode == EV_SIZING_FIT_WIDTH)
-               scale = zoom_for_size_fit_width (doc_width, doc_height, width, height);
-       else if (view->sizing_mode == EV_SIZING_BEST_FIT)
+       if (view->sizing_mode == EV_SIZING_FIT_WIDTH) {
+               gint sb_size;
+
+               sb_size = ev_view_get_scrollbar_size (view, GTK_ORIENTATION_VERTICAL);
+               scale = zoom_for_size_fit_width (doc_width, doc_height, width - sb_size, height);
+       } else if (view->sizing_mode == EV_SIZING_BEST_FIT)
                scale = zoom_for_size_best_fit (doc_width, doc_height, width, height);
        else
                g_assert_not_reached ();
@@ -6513,7 +6502,7 @@ ev_view_previous_page (EvView *view)
        if (page >= 0) {
                ev_document_model_set_page (view->model, page);
                return TRUE;
-       } else if (ev_view_get_dual_page (view) && page == -1) {
+       } else if (view->dual_page && page == -1) {
                ev_document_model_set_page (view->model, 0);
                return TRUE;
        } else {